chore(ci): make PyPI publish manual-only - #83
Merged
Merged
Conversation
PyPI publishing is done by hand via workflow_dispatch, not via the release: published trigger -- 30 of the last 39 runs were manual, and the maintainer doesn't rely on the automatic path. Dropping the event trigger removes the ambiguity around whether creating a release in bump-version.yml needs to count as an external actor.
Review of PR #83No issues found. The diff removes the Publishing to PyPI will no longer happen automatically when a GitHub release is published. Someone has to run the workflow by hand as part of each release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
release: types: [published]trigger fromrelease-package.yml, leavingworkflow_dispatchas the only way to publish to PyPI.Why
Publishing is done by hand — 30 of the last 39 runs of this workflow were manual
workflow_dispatch, only 9 fired viarelease: published. Since the automatic path isn't relied on, there's no reason forbump-version.yml's release-creation step to also need to count as an external actor (the whole point of #80's GitHub App token). This removes that requirement entirely rather than continuing to chase getting it right (see the closed #82).