Skip to content

Use Electron system directory picker - #55

Merged
wisdomqin merged 1 commit into
mainfrom
codex/fix-electron-directory-picker
Aug 17, 2026
Merged

Use Electron system directory picker#55
wisdomqin merged 1 commit into
mainfrom
codex/fix-electron-directory-picker

Conversation

@wisdomqin

Copy link
Copy Markdown
Contributor

What changed

  • route workspace directory selection through Electron dialog.showOpenDialog
  • expose a narrow preload bridge for the Harness UI
  • remove the Windows Koffi/native worker path and obsolete browse fallback patch
  • restrict picker IPC requests to the main Harness frame

Why

Packaged Windows builds could report win32 folder dialog worker exited before reporting a result. The Electron main process already owns the native window, so it should own the system directory dialog as well.

User impact

Windows and macOS now use their normal system folder picker without the crash-prone worker process.

Validation

  • npm run typecheck
  • npm test (71 tests)
  • npm run build
  • npm run package:dev:dir
  • clean npm ci --ignore-scripts followed by npm run postinstall

@wisdomqin
wisdomqin merged commit c836797 into main Aug 17, 2026
4 checks passed
@wisdomqin
wisdomqin deleted the codex/fix-electron-directory-picker branch August 17, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant