fix: keep rc.6 UI plugins compatible with keyed settings slots - #75
Draft
Yj-30422 wants to merge 1 commit into
Draft
fix: keep rc.6 UI plugins compatible with keyed settings slots#75Yj-30422 wants to merge 1 commit into
Yj-30422 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idinto the rc.7keyonly for the keyedsettings.plugin.itemslot, while keeping explicit keys authoritativeRoot cause
Harness rc.6 exposed
settings.plugin.itemas a list slot, so existing third-party bundles register anid. rc.7 changed that slot to keyed and now requiresoptions.key, causing those bundles to fail during UI startup before the desktop can render.The browser shell bundles its own SlotCore inside
@deepseek-ai/dsh-web-frontend/dist, while client plugins are served dynamically from their package bundles. The fix therefore covers both runtime paths rather than patching only the import used by tests.Fixes #74.
Related to #69.
Verification
patch-package --error-on-failnpm test— 17 files, 86 tests passednpm run typechecknpm run buildnode --checkon the actual served frontend assetgit diff --cached --checkLimitations
A packaged Electron visual launch was not performed because the Electron binary was intentionally not downloaded in this environment. The main/preload production build and runtime asset syntax checks passed. The frontend rewrite deliberately fails installation if a future Harness asset no longer matches the pinned rc.7 shape, so an upgrade cannot silently omit the compatibility shim.