refactor: batch-5 matrix server functions#497
Merged
Conversation
timcadman
marked this pull request as ready for review
July 17, 2026 10:33
Member
|
Are we sure that returning the Determinate of a Matrix is a non-disclosive operate, so can be an aggregate method? |
Contributor
Author
I'm not sure. It always has been an aggregate method, are you suggesting it should be removed? |
Contributor
Author
A small amount of chat with AI suggests that it could be disclosive. Let me chat with Demetris about this |
add minimum matrix size to reduce disclosure risk
StuartWheater
approved these changes
Jul 27, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- New treatment of assign methods appears to be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.