Repository navigation
Fix normalizer crash on comments after line continuations - #247
Closed
salapenar-max wants to merge 1 commit into
Closed
salapenar-max wants to merge 1 commit into
salapenar-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment after an explicit line continuation, such as
"\\\n#", crashes the PEP8 normalizer withAttributeError: 'NoneType' object has no attribute 'indentation'. This still reproduces on current master.The backslash introduces an indentation node while processing the same leaf prefix, so the previous indentation stack does not necessarily contain the current node. Stop the comment-indentation search at the root as well as at the current node, instead of walking into
None.Add 12 regression cases covering LF, CRLF, and CR line endings, one or two line continuations, and empty or nonempty comments. They assert that the normalizer reports the expected missing-newline diagnostic and its position.
Fixes #219.
Validation on Linux/Python 3.13.12:
python -m pytest -q: 2,000 passed, including the 12 final regression cases.git diff --checkpasses.AI disclosure: OpenAI Codex investigated the report, authored the patch and regression tests, and ran the checks on behalf of the submitting account owner.