Repository navigation
Avoid a normalizer crash after standalone line continuations - #252
Closed
rupayon123 wants to merge 1 commit into
Closed
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A source file containing a standalone line continuation followed by a comment crashes the normalizer with AttributeError instead of returning diagnostics.
The continuation prefix creates an indentation node that may not occur in the previous indentation stack. Stop the comment walk at the root in that case. Also refresh the local node after a continuation is popped, so a trailing newline does not get an incorrect indentation warning.
Closes #219.
Validation on Python 3.12.13:
Other Python runtime versions have not been run locally; grammar-version coverage is not the same as the CI runtime matrix.