Remove implicit read of .myclirc files in the current working directory#1954
Open
rolandwalker wants to merge 1 commit into
Open
Remove implicit read of .myclirc files in the current working directory#1954rolandwalker wants to merge 1 commit into
.myclirc files in the current working directory#1954rolandwalker wants to merge 1 commit into
Conversation
rolandwalker
force-pushed
the
RW/no-cwd-myclirc
branch
from
733b948 to
903360e
Compare
This was never documented, and should not have been possible without at least a warning to the user. The functionality could be added back with some form of explicit argument. Requires reformatting of test/myclirc to keep the repository git-clean after running behave. We should probably also fix that so that the behave suite does not write back to myclirc. Preparation for release 2.0.
rolandwalker
force-pushed
the
RW/no-cwd-myclirc
branch
from
903360e to
3f3196e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was never documented, and should not have been possible without at least a warning to the user. The functionality could be added back with some form of explicit argument.
Requires reformatting of
test/myclircto keep the repository git-clean after runningbehave. We should probably also fix that so that the behave suite does not write back tomyclirc.Preparation for release 2.0.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).