Add back hidden CLI arguments for recent removals#1961
Open
rolandwalker wants to merge 1 commit into
Open
Conversation
Click supports hidden+deprecated CLI arguments which are not advertised
in the helpdoc.
To make breaking changes easier and clearer, we can accept the recently
removed SSL and SSH CLI arguments in hidden+deprecated mode. If such
an option is given, the user gets a message like the following, in red:
DeprecationWarning: The option 'ssl' is deprecated. No effect. See --ssl-mode.
We should still ultimately remove (or reimplement) these hidden
arguments, since click's "hidden" property is incomplete: the hidden
arguments are still advertised in spelling-correction mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
clicksupports hidden+deprecated CLI arguments which are not advertised in the helpdoc.To make breaking changes easier and clearer, we can accept the recently removed SSL and SSH CLI arguments in hidden+deprecated mode. If such an option is given, the user gets a message like the following, in red:
We should still ultimately remove (or reimplement) these hidden arguments, since
click'shiddenproperty is incomplete: the hidden arguments are still advertised in spelling-correction mode.xref #1948, #1947
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).