Repository navigation
Bump SA-S4R to 2.0.0 and update the version floor - #44
Merged
Merged
Conversation
SA-S4R sat at 1.0.0 from 2026-06-01 until 1.1.0 and 1.1.1 this week, while its content kept changing. Two of those changes break existing users: the lookup definition was renamed from product_codes.csv to product_codes (Jul 23), and POSTing the workshop mode now needs the s4r_workshop_control capability instead of mcp_user alone (Oct 26). That is a major bump from 1.0.0, so the app goes to 2.0.0, which also covers the attack mode, the MCP tools, the CIM Web mapping, the host transform and the s4r_user role. The scripts and docs that said "SA-S4R 1.1.1+" or "older than 1.1.1" now say 2.0.0. They still check for the role, not the version, so behavior is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SA-S4R stayed at 1.0.0 from 2026-06-01 while its content evolved, and was moved to 1.1.0 and 1.1.1 only this week. A review of all 35 commits that touched
SA-S4R/found two changes that break existing users, which makes the right bump a major one:product_codes.csvbecameproduct_codes, so| lookup product_codes.csv …no longer works.s4r_workshop_control. Before,mcp_useralone could POST.Both are transparent on this stack (setup grants the capability and the docs use the new name), but an outside caller would see them.
What
SA-S4R/default/app.conf:version = 2.0.0. It covers everything since 1.0.0:s4r_userrolesetup-splunk.sh,register-s4r-mcp-tools.sh(including the two warning messages),AGENTS.md,API_REFERENCE.md,ARCHITECTURE.md,CONFIGURATION.mdandTROUBLESHOOTING.mdnow says 2.0.0.git grepfinds no 1.1.1 left.The scripts still check for the role, not the version, so behavior is unchanged.
Testing
pre-commit run --all-files,make testAfter merge:
package-s4r.ymlpublishes the 2.0.0 package aslatest. A stack only installs it on a first start of an emptyso1-etcvolume, so existing stacks keep the app they have untilmake clean-y && make up.🤖 Generated with Claude Code