Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authorization refresher silently retained stale access rules on directory load failures and repeated unchanged entry warnings every second. Collect reload diagnostics, emit new warnings and changed failures once, and report recovery without changing the last successful authorization snapshot on errors.
Move batched admission rejection reporting onto the refresher timer so counts appear even after traffic stops or every new connection is rejected. This addresses review findings #12 and #28.
Validation: all nine Linux CI jobs passed on d841d0a, including stable and Rust 1.88 tests, root end-to-end tests, clippy, formatting, dependency audit and workflow/MSRV checks. Added regressions for diagnostic changes, repeated errors and recovery, and reporting without another incoming connection. Local cargo fmt and git diff --check also pass.
Includes prerequisite #8; merge that first.