Skip to content

fix max table width - #720

Merged
ElliottKasoar merged 1 commit into
mainfrom
fix-table-width-2
Aug 5, 2026
Merged

fix max table width#720
ElliottKasoar merged 1 commit into
mainfrom
fix-table-width-2

Conversation

@joehart2001

Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

  • I've confirmed the contribution guidelines.
  • I have reviewed and understand all AI-generated code in this PR.
  • I have added human-written tests for the new logic.
  • I have properly cited any upstream algorithms or libraries the AI utilized.
  • I have disclosed significant AI tool usage in the PR description.

Summary

this seems to work well to fix the width of all components which come beneath tables

Linked issue

Resolves #

Testing

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note is this makes visualisation such as the phonons quite small. I don't mind if it's part of this PR or a separate one, but maybe it would be better to stack them vertically instead in this case, especially since we can't really zoom in on the dispersion plot?

image

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm less convinced by this, it makes some of the headings overrun

image image

@joehart2001

Copy link
Copy Markdown
Collaborator Author

ok nice spot, will take a look

@ElliottKasoar ElliottKasoar added the enhancement New feature or request label Jul 23, 2026
alinelena
alinelena previously approved these changes Jul 24, 2026
@joehart2001

Copy link
Copy Markdown
Collaborator Author

Actually I'm less convinced by this, it makes some of the headings overrun

image image

@ElliottKasoar so i dont know about this effect. the max width only effects components underneath tables so it shouldnt touch the table at all. can you compare to main to see if you get the same effect?

@ElliottKasoar

Copy link
Copy Markdown
Collaborator

Could you rebase/resolve the conflicts, @joehart2001?

@ElliottKasoar so i dont know about this effect. the max width only effects components underneath tables so it shouldnt touch the table at all. can you compare to main to see if you get the same effect?

Hmm running this again now it looks ok, so not sure what's going on...

@joehart2001

Copy link
Copy Markdown
Collaborator Author

Could you rebase/resolve the conflicts, @joehart2001?

@ElliottKasoar so i dont know about this effect. the max width only effects components underneath tables so it shouldnt touch the table at all. can you compare to main to see if you get the same effect?

Hmm running this again now it looks ok, so not sure what's going on...

i tried to check quite thoroughly and had no issues

@ElliottKasoar

Copy link
Copy Markdown
Collaborator

Could you rebase/resolve the conflicts, @joehart2001?

@ElliottKasoar so i dont know about this effect. the max width only effects components underneath tables so it shouldnt touch the table at all. can you compare to main to see if you get the same effect?

Hmm running this again now it looks ok, so not sure what's going on...

i tried to check quite thoroughly and had no issues

Yep no worries, I'm happy to merge once the conflict is fixed. We can revisit if it comes up again

@joehart2001

Copy link
Copy Markdown
Collaborator Author

@ElliottKasoar done

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joehart2001!

@ElliottKasoar
ElliottKasoar merged commit 3c1a323 into main Aug 5, 2026
14 checks passed
@ElliottKasoar
ElliottKasoar deleted the fix-table-width-2 branch August 5, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants