Repository navigation
Conversation
Collaborator
|
Thank you for the submission! I've implemented specifying encoding for pdftotext in #596. Please let us know if you have any feature requests, bugs, and contribute changes in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to use this tool to extract text from a PDF file, but it doesn't seem to support passing the encoding directly to
pdftotext.This would cause me issues with letters that aren't in the default encoding, such as ã, à, á etc. They're being saved as
�.In order to fix this, I added the
shell_encodingkwarg that would allow one to choose the correct encoding for the shell parser, pdftotext, in this case.In order to do that, I also needed to refactor a little bit the argument parsing code.
Thanks.