Repository navigation
Engagement and model viewer (spec 006, SRD Annex A Part A) - #51
Merged
Merged
Conversation
- docs/SRD.md: §7 stop clause lifted (Annex A Part B), hyperparameter cap replaced by pre-registration; §4 wall-clock cap replaced by chained CI jobs; §6 packages/demos holds the viewer; §8 decision 21 and D1-D3. - AGENTS.md: gate status (what comes next) and the demos package. - specs/006-engagement-viewer: spec (V-001..V-018 minus V-014), plan (browser-safe subpaths, @tma/demos core + React viewer, site page, tests), tasks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gv4979qzsScV5ohT5RNUoG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gv4979qzsScV5ohT5RNUoG
…ost, smoke script - /viewer page (BrowserOnly, lazy) with navbar link; prebuild writes the catalogue from the gate experiments' dataset headers and manifests and copies the carried models (4.5 MB) into site/static/viewer (ignored) - Featured bookmarks from the 2c predictions on seeds 203 and 201 held-out - Algorithm note and blog post with linked views (SC-003) - scripts/viewer-smoke.mjs: Playwright smoke of the served page - PNG export: Array.from, not a NodeList spread (Babel loose mode) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gv4979qzsScV5ohT5RNUoG
Contributor
|
Site preview: https://debrief.github.io/Gitma/pr/51/ (updates on every push; removed when the PR closes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements SRD Annex A Part A, spec 006 tasks T003 to T009. Stacked on #50: this branch contains #50's commit, so merge #50 first.
Browser-safe subpaths (T003, FR-009).
@tma/features/browser,@tma/classical/browser,@tma/eval/browserand@tma/data/canonical. They re-export the existing modules with no forks.outputsToPredictionmoves frommodelsintofeatures/decode.ts, andmodelsre-exports it. It gains an optionalfirstrow, used by the viewer to show pre-zig rows. Goldens are unchanged.@tma/demoscore (T004).@tma/eval, URL state, and NDJSON export.Tests (T005).
tfjs-nodeon the 2c LSTM, 2c BiLSTM and i1 LSTM, to float32 tolerance.React viewer (T006).
Site (T007).
/viewerpage loads the viewer browser-only and lazily, with a navbar link.site/static/viewer/, which is git-ignored.site:buildnow runstsc -bfirst, because the page imports@tma/demosfromdist/.Smoke and post (T008, T009).
scripts/viewer-smoke.mjsis a Playwright smoke test of the served page. It passes here with no console errors and every pair runs.site/docs/algorithms/viewer.mdexplains how the viewer works.Findings from the cases. These illustrate; they do not measure frequency.
Bug found and fixed. The site's Babel compiles
[...nodeList]to[].concat(nodeList), which broke the PNG export. It now usesArray.from, and the pitfall is recorded in AGENTS.md.T010, the owner's realism check, remains open.
Constitution check
schema/tma.yaml;pnpm schema:genrun (I): no schema change. The catalogue types describe viewer configuration, not pipeline records (plan, Constitution I).packages/demos/test/golden/views.ndjson, and other goldens are unchanged. Inference uses the CPU backend. Random scenario choice usescrypto.getRandomValuesand affects no output.sim/featuresstay pure functions; one CLI per stage; Keras-equivalent layers only (III): they are reused through subpaths, and the decode function moved intofeaturesunchanged.Site pages
site/docs/glossary.md) for any new term: no new termsite/docs/algorithms/viewer.md)site/blog/2026-10-17-engagement-viewer.md)Checks
pnpm lint && pnpm typecheck && pnpm test && pnpm schema:check && pnpm site:build: all pass, with 302 tests.node scripts/viewer-smoke.mjsagainst the built site: pass.Generated by Claude Code