fix(ci): use DEV registry password for DEV registry login in prod build#104
Merged
Conversation
The second modules-actions/setup step in build_prod.yml logs into the DEV registry (registry: DEV_REGISTRY, registry_login: DEV_MODULES_REGISTRY_LOGIN) but was passing PROD_MODULES_REGISTRY_PASSWORD, so 'werf cr login' to the DEV registry would fail with 'unauthorized: Auth failed' and break the prod build for every edition (ce/ee/fe/se/se-plus). Restore the DEV registry password for that login step. The build step keeps the PROD credentials, which are correct because module_source is the PROD registry. Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
NikolayDemchuk
self-requested a review
July 13, 2026 14:16
NikolayDemchuk
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The prod build (
.github/workflows/build_prod.yml) has twomodules-actions/setup@v4login steps per job: the first logs into the PROD registry, the second into the DEV registry (registry: ${{ vars.DEV_REGISTRY }},registry_login: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}).The second (DEV) step was passing the PROD password:
This changes it back to the DEV password in all editions (ce/ee/fe/se/se-plus):
The build step keeps the PROD credentials — those are correct because
module_sourcepoints to the PROD registry.Why do we need it, and what problem does it solve?
The mismatch was introduced together with the VEX attestation change. Logging into the DEV registry with the PROD password fails (
werf cr login … unauthorized: Auth failed), which breaks the prod build for every edition on tag builds. The DEV registry is thesecondary_repopush target, so a valid DEV login is required.The same defect was observed and fixed in csi-ceph (deckhouse/csi-ceph#189), where it broke the v0.5.30 release build.
What is the expected result?
A tagged prod build logs into both the PROD and DEV registries successfully and builds/pushes the module images for every edition.
Checklist