Repository navigation
feat(machines): select the create API version - #113
Closed
mehal-dedalus wants to merge 1 commit into
Closed
mehal-dedalus wants to merge 1 commit into
mehal-dedalus wants to merge 1 commit into
Conversation
Signed-off-by: Mehal <mehal@dedaluslabs.ai>
mehal-dedalus
requested a review
from Windsor Nguyễn (windsornguyen)
as a code owner
October 8, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
dedalus machines create --api-version v2to select/v2/machineson servers that support controller placement. The default remains v1. Both versions use the existing request body, credentials, transport, and output formatting.An invalid version fails before sending a request. A v2 error is returned directly without retrying the create through v1. Other Machine commands keep their v1 routes.
Verification
The new
TestCreateAPIVersioninitially failed because--api-versiondid not exist. It now runs the built CLI against a local HTTP server and passes for the default, explicit v1, explicit v2, a base URL with a path prefix, piped JSON, an invalid version, and a v2 404 without a v1 request.go test ./...passed with the repository's Steady mock API running. The mock recorded 21 structurally valid requests across all 17 endpoints.go vet ./...passed.--api-versionwith a v1 default.git diff --checkpassed.These are local CLI and HTTP-contract tests, not a real Machine placement test. Deploy server support before using v2. This change does not publish a CLI release.
Scope
117 handwritten changed lines, including 85 test lines and 13 documentation lines. No generated schema changes.
Usage documentation.