Repository navigation
fix(ssh): connect to guests through proxyjump - #114
Open
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Open
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Conversation
Signed-off-by: windsornguyen <win@dedaluslabs.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dedalus sshnow connects to the guest through the gateway with OpenSSHProxyJump. It writes a private configuration with separate certificates and host trust for the guest and gateway, and rejects responses without the jump-host contract.The consumer test builds the CLI, serves an API response, and checks both hops with the actual OpenSSH configuration parser. It also checks credential permissions, temporary paths containing spaces, and rejection of a missing jump host. The README shows the shell command and its OpenSSH requirement.
Verification
GOMAXPROCS=2 GOFLAGS=-p=2 ./scripts/test -count=1passes with Steady 0.22.1 serving the repository's pinned public OpenAPI fixture. This includes the full native test suite and Windows test compilation.GOMAXPROCS=2 GOFLAGS=-p=2 go test -race -count=1 -run '^TestSSHConsumerUsesTwoHopContract$' ./pkg/cmdpasses.GOMAXPROCS=2 GOFLAGS=-p=2 ./scripts/lintpasses.Release requirement
The API must return the guest connection with its raw host key and a
jump_hostcontaining the gateway certificate and host CA trust before this CLI is released. The pinned Go SDK preserves that response inRawJSON, so this change does not require an SDK version update. Windows compilation is checked; the native OpenSSH runtime check was performed on Linux.