Repository navigation
Conversation
electron-builder compiles installer.nsh twice (installer pass and BUILD_UNINSTALLER pass) and elevates makensis warnings to errors. The installer pass emitted both RemovePathSegment variants but only references the non-un. one (and vice versa), so the unreferenced variant failed the build with warning 6010. Emit only the variant each pass references. This is the root cause of the desktop-build.yml failures on dev.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
desktop-build.yml has been failing on dev. electron-builder compiles
resources/installer.nshtwice — once for the installer pass and once for theBUILD_UNINSTALLERpass — and elevates makensis warnings to errors. Each pass emitted bothRemovePathSegmentfunction variants (plain andun.) but only references its own, so the unreferenced variant failed the build with makensis warning 6010 (function not used).Reproduced locally: byte-identical error to CI run 36264758680.
Fix
Wrap the two
!insertmacro RemovePathSegmentcalls in!ifdef BUILD_UNINSTALLER / !else / !endifso each pass emits only the variant it references.Verification
npx electron-builder --win nsis --x64 --publish nevernow succeeds locally (produceddeepagent-code-desktop-win-x64.exe; installs and uninstalls cleanly on a real Windows 11 machine).