tests: make the paper-trading compatibility suite compile again (ibx#397) - #398
Open
userFRM wants to merge 1 commit into
Open
tests: make the paper-trading compatibility suite compile again (ibx#397)#398userFRM wants to merge 1 commit into
userFRM wants to merge 1 commit into
Conversation
`tests/ib_paper_compat` has not built. Thirteen call sites construct request and command variants that have since gained fields, so the whole target fails to compile and every phase in it is dead code — fourteen entry points driving a hundred and fifty-four phases against a paper account. Nothing reported it because the suite only runs against live credentials, so ordinary development never builds it, and `cargo check` without a target name does not reach it either. The fields each site is missing were added with defaults in mind: contract-details filters, the optional initial trailing-stop trigger, and the adjustable stop's trailing amount and unit. Each site now passes the value it would have had before those fields existed, which is what the phases were written against. No phase behaviour changes. This is the difference between a suite that cannot be run and one that can. Closes deepentropy#397.
userFRM
added a commit
to userFRM/ibx
that referenced
this pull request
Aug 3, 2026
…te compile again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/ib_paper_compatdoes not build. Thirteen call sites construct request and command variants that have since gained fields, so the whole target fails to compile and every phase in it is dead — fourteen entry points driving a hundred and fifty-four phases against a paper account.Nothing reported it. The suite only runs with live credentials, so ordinary development never builds it, and
cargo checkwithout a target name does not reach it.It had also quietly become the baseline: work in this repo compares the suite's error set before and after a change to show nothing broke. Thirteen errors is the number being matched, which makes a broken target look like a fixed point.
What this changes
Each site gets the value it would have had before those fields existed — default contract-details filters, no initial trailing-stop trigger, no adjustable trailing amount or unit. No phase behaviour changes.
The target now compiles clean and enumerates its fourteen tests.
Why it matters
This is the only end-to-end coverage against a real gateway. Every wire-level claim in this repo currently rests on unit tests and reasoning, with nothing exercising a full session — which is the coverage that catches a tag emitted in the wrong position, an order the gateway rejects, or a reply the parser mishandles.
Run against a paper account
With it building, the suite runs. All seven phases pass:
So the phases still describe the server's behaviour correctly — the suite had gone stale in its call sites, not in what it asserts.
Keeping it built
cargo check --testsreaches every target by name and would have caught each of these on the day the field was added. #300 adds a CI workflow; this belongs in it.Closes #397.