Skip to content

ci: DH-22019: Disable app armor on benchmark servers - #429

Merged
stanbrub merged 6 commits into
deephaven:mainfrom
stanbrub:disable-app-armor
Jul 30, 2026
Merged

ci: DH-22019: Disable app armor on benchmark servers#429
stanbrub merged 6 commits into
deephaven:mainfrom
stanbrub:disable-app-armor

Conversation

@stanbrub

Copy link
Copy Markdown
Collaborator
  • Turn off apparmor for the whole test system
  • Turn off apparmor for each docker compose startup

@stanbrub stanbrub self-assigned this Jul 30, 2026
@stanbrub
stanbrub requested a review from Copilot July 30, 2026 19:45
@stanbrub stanbrub changed the title Disable app armor feat: Disable app armor Jul 30, 2026
@stanbrub stanbrub changed the title feat: Disable app armor ci: Disable app armor on benchmark servers Jul 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables AppArmor for the benchmark/test environment by (1) turning it off at the host level during remote test-server setup and (2) configuring Docker Compose to run the deephaven container without AppArmor confinement.

Changes:

  • Disable AppArmor on the remote test server during provisioning (systemctl + aa-teardown).
  • Add security_opt: [apparmor:unconfined] to deephaven service definitions in multiple benchmark Docker Compose files.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.github/scripts/setup-test-server-remote.sh Disables AppArmor on the test host during setup.
.github/resources/release-benchmark-docker-compose.yml Runs deephaven with AppArmor unconfined.
.github/resources/nightly-benchmark-docker-compose.yml Runs deephaven with AppArmor unconfined.
.github/resources/integration-docker-compose.yml Runs deephaven with AppArmor unconfined.
.github/resources/compare-benchmark-docker-compose.yml Runs deephaven with AppArmor unconfined.
.github/resources/adhoc-benchmark-docker-compose.yml Runs deephaven with AppArmor unconfined.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/setup-test-server-remote.sh
Comment thread .github/resources/release-benchmark-docker-compose.yml
Comment thread .github/resources/nightly-benchmark-docker-compose.yml
Comment thread .github/resources/integration-docker-compose.yml
Comment thread .github/resources/compare-benchmark-docker-compose.yml
Comment thread .github/resources/adhoc-benchmark-docker-compose.yml
@stanbrub stanbrub changed the title ci: Disable app armor on benchmark servers ci: DH-22019: Disable app armor on benchmark servers Jul 30, 2026
@stanbrub
stanbrub merged commit cacc2a0 into deephaven:main Jul 30, 2026
4 checks passed
@stanbrub
stanbrub deleted the disable-app-armor branch July 30, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants