feat(csharp/client): DH-23198: Gradle support for testing C# client - #8295
Merged
Conversation
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for 4bd9bc8 |
niloc132
previously approved these changes
Jul 30, 2026
Comment on lines
+40
to
+61
| dockerfile { | ||
| from(Docker.localImageName('dotnet')) | ||
| environmentVariable 'DOTNET_CLI_TELEMETRY_OPTOUT', '1' | ||
| environmentVariable 'DOTNET_NOLOGO', '1' | ||
| // The SDK image only carries the net10.0 runtime; graft in the net8.0 | ||
| // runtime from the (digest-pinned) official runtime image so that both | ||
| // target frameworks of the test project can execute. | ||
| copyFile(new Dockerfile.CopyFile( | ||
| '/usr/share/dotnet/shared/Microsoft.NETCore.App', | ||
| '/usr/share/dotnet/shared/Microsoft.NETCore.App/') | ||
| .withStage(Docker.localImageName('dotnet-runtime-8'))) | ||
| workingDir('/project') | ||
| copyFile('.', '/project/') | ||
| runCommand('''set -eux; \\ | ||
| mkdir /out; \\ | ||
| dotnet restore /project/csharp/client/Dh_NetClientTests/Dh_NetClientTests.csproj; \\ | ||
| dotnet build /project/csharp/client/Dh_NetClientTests/Dh_NetClientTests.csproj \\ | ||
| -c Release --no-restore | ||
| ''') | ||
| environmentVariable 'DH_HOST', deephavenDocker.containerName.get() | ||
| environmentVariable 'DH_PORT', '10000' | ||
| } |
Member
There was a problem hiding this comment.
If it would be easier to read/maintain, this can also be written as a plain Dockerfile and we can reference it from here.
Contributor
Author
There was a problem hiding this comment.
OK, moved to separate Dockerfile. Also added a global.json file so that the thing is now invocable as "dotnet test"
kosak
force-pushed
the
kosak_test-csharp-with-gradle
branch
from
August 7, 2026 20:29
27268bb to
4bd9bc8
Compare
niloc132
approved these changes
Aug 7, 2026
jcferretti
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly written by Claude, with me nagging now and then. Bugs and feature requests should be sent to claude@dev.null