chore: Bump to deephaven-plugin>=0.8.0 - #159
Merged
Merged
Conversation
devinrsmith
approved these changes
Aug 5, 2026
devinrsmith
left a comment
devinrsmith
left a comment
Member
There was a problem hiding this comment.
I think the currently caching behavior is as-desired. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side note: Our nightly action builds from the same cache, since the requirements.txt file hasn't changed. So even though a new deephaven-plugin v0.8.0 has been published, and requirements.txt had
deephaven-plugin>=0.6.0, it was not updated in the nightly build because the requirements.txt did not change (causing the cache not to rebuild: https://github.com/deephaven/deephaven-server-docker/blob/main/contexts/server-base/Dockerfile).Is that intentional? Or should these nightly images actually be updated nightly based on the ranges provided?