Skip to content

fix: DH-23176: Better Error Handling for Conditional Formatting - #2731

Open
dgodinez-dh wants to merge 12 commits into
deephaven:mainfrom
dgodinez-dh:dag_ConditionalFormatErrorHandling
Open

fix: DH-23176: Better Error Handling for Conditional Formatting#2731
dgodinez-dh wants to merge 12 commits into
deephaven:mainfrom
dgodinez-dh:dag_ConditionalFormatErrorHandling

Conversation

@dgodinez-dh

Copy link
Copy Markdown
Contributor
  • adds conditional formats and preview to IrisGrid rollback
  • displays and error message in the Conditional Format UI for failed formats

@dgodinez-dh
dgodinez-dh requested review from a team and mattrunyon and removed request for a team August 5, 2026 13:23
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.21%. Comparing base (29750de) to head (a7ac56d).

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGrid.tsx 30.00% 7 Missing ⚠️
...conditional-formatting/ConditionalFormatEditor.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2731      +/-   ##
==========================================
- Coverage   51.40%   51.21%   -0.19%     
==========================================
  Files         796      796              
  Lines       45847    45855       +8     
  Branches    11719    11725       +6     
==========================================
- Hits        23566    23485      -81     
- Misses      22262    22351      +89     
  Partials       19       19              
Flag Coverage Δ
unit 51.21% <60.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant