Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [Kylin] Input: i8042 - skip the 706 boards whose KBC does not answer - #2224

Merged
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:fix/i8042-kylin-list
Oct 23, 2026
Merged

opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:fix/i8042-kylin-list

Conversation

@opsiff

@opsiff opsiff commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

The Kylin LPC driver carries a machine table for the 706 laptops whose KBC interfaces have to stay disabled. They hang the same way as the KaiTian board already listed, so skip i8042 on them as well.

Summary by Sourcery

Bug Fixes:

  • Skip i8042 initialization on five additional HT706 706 laptop models whose KBC interfaces do not respond and can hang the system.

The Kylin LPC driver carries a machine table for the 706 laptops whose KBC
interfaces have to stay disabled.  They hang the same way as the KaiTian
board already listed, so skip i8042 on them as well.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai

sourcery-ai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

The patch prevents i8042 initialization on five Kylin 706 laptop variants by adding their DMI identifiers to the existing Phytium skip table, matching the handling of other boards with non-responsive KBCs.

Flow diagram for skipping i8042 on Kylin 706 laptops

flowchart TD
    A[System boot] --> B[DMI identification]
    B --> C{Matches phytium_i8042_skip}
    C -->|HT706 TR4251, TR4252, TR4260, TR4261, or TR4263| D[Skip i8042 initialization]
    C -->|No match| E[Initialize i8042]
Loading

File-Level Changes

Change Details Files
Extend the i8042 DMI skip list for Kylin 706 laptops whose KBC does not respond.
  • Add DMI matches for the five HT706/TR42xx board combinations.
  • Keep these systems out of i8042 probing to avoid the known hang behavior.
drivers/input/serio/i8042-phytio.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@opsiff
opsiff merged commit b2783ca into deepin-community:linux-6.6.y Oct 23, 2026
13 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants