Lightsail as the default 1-click template, with the Remote Control name fix - #163
Open
defangdevs wants to merge 4 commits into
Open
Lightsail as the default 1-click template, with the Remote Control name fix#163defangdevs wants to merge 4 commits into
defangdevs wants to merge 4 commits into
Conversation
The Lightsail template hardcoded remoteControlName = "<user>@<stack>", so the entry in the Claude apps named the CloudFormation stack — which says nothing about how to reach the box — and pinned one name for every session the user runs, since remoteControlName is per-user rather than per-session. Drop it and set remoteControlHost = hostname instead, mirroring aws/template.yaml. Sessions are then identifiable as "<user>-<session>@<host>", where <host> is the sslip.io address the box is actually reached at, and runtime-added sessions get distinct names. The stack Output moves in lockstep (it advertised the old name), using the same dashed-IP form the userdata bakes into the hostname and that WebUrl already reports. The Fn::Sub StackName variable is now unused, so it goes too. README's EC2 walkthrough claimed the same <UserName>@<stack name> shape; that has been stale since aws/template.yaml started setting remoteControlHost, so it is corrected here as well. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsqGhkpjsb4kKAdVz25xKN
PR #150 makes lightsail-template.yaml the template the Launch buttons use, which falsifies three claims in aws/README.md that it left untouched: the quick-create note and the publish-verification curl both named template.yaml as the only published object, and the PR-validation section described a cfn-lint invocation that aws-ci.yml already widened to both templates.
…page The landing page still told users the Claude apps show "<user>@<stack name>" and to rename the stack for a friendlier label. Both templates now set remoteControlHost to the box's sslip.io address, so the name is derived per session and the stack name has no bearing on it.
This was referenced Aug 2, 2026
lionello
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #150 and #156 into one branch, rebased onto current
master.They belong together: #150 makes Lightsail the template the Launch buttons point at, and #156 fixes the Remote Control session name in that same template. Merging #150 alone would ship the new default while still advertising
<user>@<stack name>; merging #156 alone leaves the fix on a template nobody launches.What's here
Revert "Revert Lightsail as the default 1-click template"fix(lightsail): derive Remote Control name from the public hostdocs(aws): point the publish/CI notes at both templatesdocs(site): drop the stack-name Remote Control label from the launch pageConflicts resolved
master(why Lightsail as the default 1-click template #150 shows as CONFLICTING):AGENTS.md—mastergrew the multi-arch checks paragraph next to thecfn-lintline that Lightsail as the default 1-click template #150 rewrites. Kept both: the paragraph verbatim frommaster, the two-templatecfn-lintline from Lightsail as the default 1-click template #150.README.md— both edit the same sentence. Lightsail as the default 1-click template #150 rewrites the section around it for Lightsail but carries the stale<UserName>@<stack name>claim forward; fix(lightsail): derive Remote Control name from the public host #156 replaces that claim. Took fix(lightsail): derive Remote Control name from the public host #156's sentence inside Lightsail as the default 1-click template #150's Lightsail paragraph, which is the state both PRs were aiming at.The two new commits
Both fix claims that this combination falsifies and that neither PR updated, because in isolation neither had reason to:
aws/README.mdstill said the Launch links point attemplate.yaml, verified a publish with acurlagainsttemplate.yamlonly, and described PR CI as runningcfn-lint aws/template.yaml(aws-ci.ymlonmasteralready lints both).docs/index.html— the public landing page — still told users the Claude apps showagent@agent-boxand to rename the stack for a friendlier label. WithremoteControlHostset on both templates the stack name no longer has any bearing on the session name, so that instruction sends users to do something with no effect.Verification
cfn-lint aws/template.yaml aws/lightsail-template.yaml— clean (whataws-ci.ymlruns).publish-template.yml's default-injectionawkagainst both templates and asserted all fourDefault:lines land — the workflow now pinslightsail-template.yamltoo, and that step hard-fails if a template's parameter layout doesn't match. It matches.cfn-linton both injected copies is also clean.RemoteControlSessionOutput againstWebUrl: both derive the host asJoin['-', Split['.', StaticIp.IpAddress]], and the userdata bakes the same form intohostname(dom="$(echo "$ip" | tr . -).sslip.io",aws/lightsail-template.yaml:325) — so the advertised name is the one the box actually registers.modules/agent-box.nix.inthatremoteControlHostyields<user>-<session>@<host>, matching what the docs now claim.<stack name>Remote Control claims: none.77e3e73). This branch is the linear one.Not deploy-tested: no Lightsail stack launched, and #156's change lives in userdata that only runs on first boot. Inherited from #156, unchanged. A real launch before merge would confirm the Output end-to-end.
Closes #150. Closes #156.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PsqGhkpjsb4kKAdVz25xKN