Repository navigation
Conversation
Vendors @herb-tools/linter 0.11.1 (170 rules, up from 100) and bumps the herb gem dependency to ~> 0.11.1.
- Rebuild the bundle from dist/index.js, adding build-time stubs for the Node-only paths in postcss (path/fs/url/util/picocolors).
- Implement HerbBackend#defaultERBOpenings and forward the new parser options (herb_directives, iteration_nodes, erb_openers).
- Read .herb.yml's top-level framework and thread it through Runner/Bridge; Action View rules now run only under framework: actionview.
- Make explicit rule selection (--only / rules:) bypass framework, environment, and path filters, matching upstream Linter.from({ only }).
- Add conformance fixtures for all 170 registered rules; document two pending partial-index rules and two rules upstream 0.11.1 cannot trigger from the CLI.
- Bump gem version to 0.11.1.0 and update docs/changelog.
andyw8
marked this pull request as ready for review
October 20, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades the vendored linter from
@herb-tools/linter0.10.3 to 0.11.1(and the
herbgem dependency to~> 0.11.1). The rule set grows from 100to 170 rules.
Notable changes:
dist/index.jsentry point.HerbBackend#defaultERBOpeningscallback.herb_directives,iteration_nodes,erb_openers..herb.yml's top-levelframeworkand thread it throughRunner/Bridge,so Action View rules run under
framework: actionview.--only/rules:) bypass framework,environment, and path filters, matching upstream
Linter.from({ only }).rules now pull postcss into the bundle.
Two conformance cases are pending because upstream needs a project-wide partial
index the standalone harness doesn't build. Two more are asserted bridge-only
because upstream 0.11.1 computes parser options before merging config
framework, so the reference CLI cannot trigger them.Does this change affect the no-Node guarantee?
No. Node remains build-time only. The new postcss dependency's Node-only
source-map/terminal-color paths are replaced at build time with filesystem-free
stubs (
stubs/fs.mjs,stubs/path.mjs, etc.), and the bundle build's existingNode-builtin check still passes. Runtime code paths are unchanged in this
respect;
bundle exec rake(includingspec/no_node_spec.rb) passes.Test coverage
frameworkconfig parsing, framework threading through thebridge/runner, rule framework metadata, and the new forwardable parser options.
bundle exec rakepasses: RuboCop clean, RSpec 281 examples / 0 failures(2 pending),
bundler-auditclean.bundle exec rake buildproducespkg/herb-embedded-0.11.1.0.gem.CHANGELOG
Added an entry under
## unreleasedinCHANGELOG.md.