Add embedded terminal tabs - #624
Conversation
Close temporary batch terminal tabs after script execution, split terminal responsibilities into focused classes, add terminal unit coverage, and make size-formatting tests locale-aware.
|
Hi ph10w, this looks like a more significant change, so I appreciate the work you've put into it. I think it needs some justification, though. Is there a particular reason why running a terminal embedded in a tab is better than running it externally? Also, is |
|
Hi David, |
Overview
The standard Open Command Prompt action now opens
cmd.exein an Explorer++ tab. Elevated terminals remain external, with the existing command prompt used as a fallback when the embedded terminal is unavailable. Activating.bator.cmdfiles opens a temporary terminal tab that closes when the script finishes.Architecture
HwndTerminalcontrol and connects it tocmd.exethrough ConPTY.Microsoft.Terminal.Control.dlldynamically from the application directory and includes it in portable and MSI packages with attribution.exit.Behavior
cdchanges in the tab title and tooltip, and closes interactive tabs when their command process exits.Checks performed
Explorer++andTestExplorer++inRelease|x64with 0 warnings and 0 errors.exit→ reopen, confirming that the path prompt appears immediately and remains usable.