Skip to content

chore(webapp): migration to vuetify 4 - #1214

Open
Ph0tonic wants to merge 8 commits into
desec-io:mainfrom
Ph0tonic:vuetify_4
Open

chore(webapp): migration to vuetify 4#1214
Ph0tonic wants to merge 8 commits into
desec-io:mainfrom
Ph0tonic:vuetify_4

Conversation

@Ph0tonic

@Ph0tonic Ph0tonic commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Hey,
I tried to upgrade to vuetify 4 but I also needed to upgrade:

  • vue-router 5
  • pinia 4

I removed vue-demi which did not seemed to be used.

I also update the qrcode-vue inlined repo to a vue3 version, allowing to simplify it's vue integration.

Replaces #1211

@Ph0tonic Ph0tonic mentioned this pull request Jul 28, 2026
@peterthomassen

Copy link
Copy Markdown
Member

Thanks for doing this, this looks pretty good!

I didn't find any functionality that broke, but there are several changes in how things look. Some of that is fine (for example, whether the sign-up button is uppercase or lowercase), but others are more significant for flow / smooth perception:

  • In a large browser window, the padding to the left/right of the main body text is gone
  • Sometimes there is weird spacing, such as between the checkboxes in the sign-up form
  • Sometimes, fonts have wrong size. Example: in the domain list, click on the (i) to see configuration details. The "copy" buttons have significantly oversized labels

If you have some time, would you mind "playing through" as much GUI functionality as you can, and note down if you spot anything odd? There's no need for immediate fixes; the list will suffice for a start. We can then see what's easy to fix / significant or not / where assisted coding can help etc.

🙏

Ph0tonic added 7 commits July 31, 2026 16:53
Vite 8 / rolldown require Node ^20.19.0 || >=22.12.0 (uses node:util's
styleText, added in Node 20.12). CI was still pinned to Node 18.
- Restore h1-h6 margins dropped by v4's CSS-reset removal
- Fix oversized copy-button labels in card titles (v4 moves component
  styles into cascade layers, so buttons inherited the card-title font)
- Replace dead text-subtitle-1 class on DonatePage (v4 typography rename)
- Add no-gutters to sign-up/activate-account checkbox rows (v4 grid gap)
Vuetify 4 (MD3) dropped the default accent color on selection controls,
so switches looked grey whether on or off. Set an explicit color to make
the state easy to read at a glance.
@Ph0tonic

Copy link
Copy Markdown
Contributor Author

Hey @peterthomassen,

I played with the UI and fixed everything I could find.

I also made a change to the switches: I noticed it was hard to tell whether they were on or off, so I gave them a color (Vuetify 4 dropped the default accent color on switches, so they render grey either way now). It makes the state much easier to read at a glance.

Let me know what you think!

@Ph0tonic
Ph0tonic force-pushed the vuetify_4 branch 2 times, most recently from a022e62 to a90e557 Compare July 31, 2026 15:18
@Ph0tonic Ph0tonic changed the title Vuetify 4 chore(webapp): migration to vuetify 4 Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants