ci: verify ksail release downloads - #2738
Draft
devantler wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
Contributor
Author
|
@cursor review |
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_1112ba5d-85be-4bd3-a638-b5ff56ffb1fd) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.github/scripts/setup-ksail.shthat downloads the pinned KSail release asset and verifies itssha256digest from the GitHub release metadata before extracting and installing the binary.curl | tar | sudo installKSail steps with calls to the verified installer in.github/actions/deploy-prod/action.yml,.github/workflows/ci.yaml, and.github/workflows/dr-rebuild.yamlso the asset is validated before any credentials are written orksailis invoked.# renovate:pins and metadata-based tracking forKSAIL_VERSIONwhile adding runtime integrity checking to the install path.ci: verify ksail release downloads(HEAD:1f9a0400).Testing
git diff --checkandbash -n .github/scripts/setup-ksail.shwith no syntax errors, which succeeded.PATH-shimmedcurl/sudo/ksail) that exercised release JSON parsing andsha256sum --check, which verified the digest and simulated a successful install.Codex Task