fix(headlamp): disable unverified plugin downloads - #2741
Conversation
|
|
@cursor review |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_21888ef5-de1d-4067-bac4-c1d59cb80996) |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Static exact-head review of 0df00b3df74b775ad27c0fee06ad79e5e33f12ad. One blocking finding is inline below. I did not check out or execute this ownership-unverified branch.
| installOptions: | ||
| parallel: true | ||
| maxConcurrent: 3 | ||
| enabled: false |
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
[P1] Replace dynamic downloads without orphaning plugin state
This stops the plugin manager, but the current deployment still creates the headlamp PVC and replaces plugins-dir with that persistent volume, so existing clusters retain the previously downloaded JavaScript rather than revoking it. A clean install has the opposite failure: it receives no plugins, while Crossview’s current manifest states that crossview-headlamp is its only entry point. Please deliver an integrity-bound, GitOps-managed plugin bundle (or another authenticated Crossview route), migrate/delete the old plugin PVC, and prove both upgrade and fresh-install paths.
Motivation
Description
k8s/bases/apps/headlamp/helm-release.yamlsetconfig.watchPlugins: falseandpluginsManager.enabled: false, and add a clarifying comment explaining the integrity rationale.k8s/bases/apps/headlamp/cilium-network-policy.yamlremove runtime egress allow-list entries forartifacthub.io, GitHub release asset hosts, andregistry.npmjs.org, leaving only Dex OIDC egress required for authentication.Testing
python3 scripts/validate-embedded-json.py, which succeeded.python3 scripts/validate-naming.py, which succeeded.git diff --checkandgit statusto validate no whitespace / diff issues, which succeeded.ksail workload validateorkubectl kustomizein this environment becauseksailandkubectlare not installed, and a local YAML parse check using Pythonyamlwas not run because theyamlmodule was unavailable; those validations should be executed in CI or a maintainer environment before merge.Codex Task