Skip to content

Add critique.work feature - #139

Merged
sebst merged 4 commits into
mainfrom
copilot/add-critique-work-feature
Mar 21, 2026
Merged

sebst merged 4 commits into
mainfrom
copilot/add-critique-work-feature

Conversation

Copilot AI commented Mar 21, 2026 •

Copy link
Copy Markdown
Contributor

Adds a devcontainer feature for critique, a terminal UI for reviewing git diffs with syntax highlighting, split view, and word-level diff.

Notable implementation detail

Critique has no standalone binary releases — it's a Bun package installed via bun install -g critique. The install script handles this by bootstrapping Bun system-wide (BUN_INSTALL=/usr/local) if not already present, placing both bun and critique under /usr/local/bin.

Changes

  • src/critique.work/devcontainer-feature.json — feature metadata; exposes a version option (latest or X.Y.Z)
  • src/critique.work/install.sh — installs Bun to /usr/local if absent, then runs bun install -g critique[@VERSION]
  • test/critique.work/test.sh — asserts /usr/local/bin/critique exists post-install
  • .github/workflows/test.yaml — adds critique.work to both test-autogenerated and test-scenarios matrices

Usage

"features": {
    "ghcr.io/devcontainer-community/devcontainer-features/critique.work:1": {}
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/remorses/critique/releases
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Add critique.work feature</issue_title>
<issue_description>Files:

src/<FeatureName>/devcontainer-feature.json
src/<FeatureName>/install.sh (make sure to set executable bit)
test/<FeatureName>/test.sh
.github/workflows/test.yaml

Releases:

https://github.com/remorses/critique/releases</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Add critique.work feature Add critique.work feature Mar 21, 2026
Copilot AI requested a review from sebst March 21, 2026 17:01
@sebst
sebst marked this pull request as ready for review March 21, 2026 17:03

@sebst sebst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail

Copilot AI commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

tests fail

Fixed in 0b5b60a. The root cause was BUN_INSTALL=/usr/local being used as a per-command env prefix for curl, which only applied to curl and not to the piped bash subprocess. So bun installed to ~/.bun/bin/bun instead of /usr/local/bin/bun, causing bun: command not found on the next line. Changed both assignments to export BUN_INSTALL=/usr/local so the bun install script and subsequent bun install -g both see the correct install path.

Copilot AI requested a review from sebst March 21, 2026 17:54
@sebst
sebst merged commit 3d9ef1a into main Mar 21, 2026
7 checks passed
@sebst
sebst deleted the copilot/add-critique-work-feature branch March 21, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add critique.work feature

2 participants