Add critique.work feature - #139
Merged
Merged
Conversation
Co-authored-by: sebst <592313+sebst@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/4c501d49-0ccb-464e-8c31-8cc0db8d2815
Co-authored-by: sebst <592313+sebst@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/e23bc9d2-8c61-40bb-a3fa-b94a4011fd6d
Contributor
Author
Fixed in 0b5b60a. The root cause was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a devcontainer feature for critique, a terminal UI for reviewing git diffs with syntax highlighting, split view, and word-level diff.
Notable implementation detail
Critique has no standalone binary releases — it's a Bun package installed via
bun install -g critique. The install script handles this by bootstrapping Bun system-wide (BUN_INSTALL=/usr/local) if not already present, placing bothbunandcritiqueunder/usr/local/bin.Changes
src/critique.work/devcontainer-feature.json— feature metadata; exposes aversionoption (latestorX.Y.Z)src/critique.work/install.sh— installs Bun to/usr/localif absent, then runsbun install -g critique[@VERSION]test/critique.work/test.sh— asserts/usr/local/bin/critiqueexists post-install.github/workflows/test.yaml— addscritique.workto bothtest-autogeneratedandtest-scenariosmatricesUsage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/remorses/critique/releases/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.