Skip to content

Update asdf-vm feature to support 0.18.x - #82

Merged
sebst merged 3 commits into
mainfrom
copilot/update-asdf-vm-version
Mar 16, 2026
Merged

sebst merged 3 commits into
mainfrom
copilot/update-asdf-vm-version

Conversation

Copilot AI commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

The asdf-vm feature was pinned to proposals listing only latest, while the underlying install logic already supported binary installations for versions > 0.16.0 (the Go-based rewrite). This PR explicitly surfaces the current stable releases in the proposals list and bumps the feature version.

Changes

  • devcontainer-feature.json
    • Bump feature version 1.0.1 → 1.0.2
    • Add 0.18.1 and 0.18.0 to options.version.proposals

No install.sh changes required

The binary install path already handles 0.18.x correctly:

  • Versions > 0.16.0 use install_binary(), which downloads asdf-v${VERSION}-${os}-${arch}.tar.gz from GitHub releases — the exact asset naming used by 0.18.x releases
  • Default "latest" resolves via GitHub API, so 0.18.1 installs automatically without any explicit version pin

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/asdf-vm/asdf/releases/latest
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Please update asdf-vm</issue_title>
<issue_description>asdf-vm currently installs version 0.15.0.

Please update the feature to install latest asdf version 0.18.0 and follow up on the configuration changes</issue_description>

<agent_instructions>- adapt version in devcontainer-feature.json and install.sh if needed

  • bump version of asdf-vm in devccontainer-feature.json

  • test installation</agent_instructions>

Comments on the Issue (you are @copilot in this section)


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: sebst <592313+sebst@users.noreply.github.com>
Copilot AI changed the title [WIP] Update asdf-vm to install version 0.18.0 Update asdf-vm feature to support 0.18.x Mar 16, 2026
Copilot AI requested a review from sebst March 16, 2026 13:37

@sebst sebst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail:

ERROR: failed to build: failed to solve: process "/bin/sh -c cp -ar /tmp/build-features-src/asdf-vm.com_0 /tmp/dev-container-features  && chmod -R 0755 /tmp/dev-container-features/asdf-vm.com_0  && cd /tmp/dev-container-features/asdf-vm.com_0  && chmod +x ./devcontainer-features-install.sh  && ./devcontainer-features-install.sh  && rm -rf /tmp/dev-container-features/asdf-vm.com_0" did not complete successfully: exit code: 127

Co-authored-by: sebst <592313+sebst@users.noreply.github.com>

Copilot AI commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

Tests fail:

Fixed in 94b46bb. The root cause was that github_get_latest_release() uses curl before any package installation step, so on minimal images like debian:latest where curl isn't pre-installed it fails with exit code 127. The fix adds a command -v curl check at the start of install() and installs curl via apt_get_checkinstall if it's not already present — safe for non-apt systems (e.g. macOS where curl is always bundled) since it's guarded by the command -v check.

Copilot AI requested a review from sebst March 16, 2026 13:47
@sebst
sebst marked this pull request as ready for review March 16, 2026 13:51
@sebst
sebst merged commit bd0674f into main Mar 16, 2026
78 of 81 checks passed
@sebst
sebst deleted the copilot/update-asdf-vm-version branch March 16, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please update asdf-vm

2 participants