TUI: split-view docs and page navigation (#78, #76)#82
Merged
Conversation
The feature bullet described the A view as combining multiple layers into one virtual tree, which is not what it does and misled at least one user into expecting a diff between two arbitrary layers. It is a layer-against-its-own-history view: the selected layer's delta on top, the cumulative filesystem at that layer below, both driven by the layer selection. Fix the misleading bullet, sharpen the keybinding-table row, and add a Split view (A) subsection explaining what each half shows and how to drive it from the layers pane. Closes #78
The README section clears up the misconception but stays terse. Add a standalone docs/split-view.md that explains the A view in plain language first (top is the change, bottom is the result), then goes deep: a worked nginx example, how Tab drives the layers pane and both halves, a side-by-side table of what each pane computes, an explicit 'what it is not' section for the layer-vs-layer expectation, and the toggle's state behaviour (filters carry over, cursor resets). Note the key is A i.e. Shift+a, since users ask. Link the guide from the README split-view section, matching how the other feature docs are cross-referenced. Refs #78
Large file trees were slow to traverse with only j/k line motion and g/G jump-to-end. Add vim-style paging: Ctrl-d/Ctrl-u for half a screen and Ctrl-f/Ctrl-b (plus PgDn/PgUp aliases) for a full screen. Paging is cursor-based to match the existing g/G/j/k behaviour, and the step is derived from each pane's own visible height so it stays correct in the split view and after a resize. It works in both the file tree and the layers pane; on the layers pane a page jump changes the selected layer and resets the tree to follow, exactly as a single-step move does. Closes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two interactive-TUI improvements.
#76 — Page / half-page navigation
Large file trees were slow to traverse with only
j/kline motion andg/Gjump-to-end. Added vim-style paging:Ctrl-d/Ctrl-u— half a screen down / up.Ctrl-f/Ctrl-b(alsoPgDn/PgUp) — a full screen down / up.Paging is cursor-based to match the existing
g/G/j/kbehaviour, and the step is derived from each pane's own visible height so it stays correct in the split view and after a resize. Works in both the file tree and the layers pane; on the layers pane a page jump changes the selected layer and resets the tree to follow. Documented in the README keybinding table and the in-app help overlay.#78 — Document the split view (
A)The README described the
Aview as combining multiple layers into one virtual tree, which is not what it does — it misled at least one user into expecting a layer-vs-layer diff. TheAview is a layer-against-its-own-history view: the selected layer's delta on top, the cumulative filesystem at that layer below, both driven by the layer selection in the layers pane.A) subsection to the README.nginxexample, a side-by-side table of what each pane computes, an explicit "what it is not" section, and the toggle's state behaviour. Notes that the key isA(Shift + a).Testing
Ctrl-fandPgDn. Verified interactively against a real image.The layout-orientation toggle (#79) is intentionally not part of this PR — it needs its own branch and a deeper UX evaluation.