Skip to content

tests: Miscellaneous fixes for the test suite#2929

Draft
JDBetteridge wants to merge 6 commits into
mainfrom
JDBetteridge/misc_test_fixes
Draft

tests: Miscellaneous fixes for the test suite#2929
JDBetteridge wants to merge 6 commits into
mainfrom
JDBetteridge/misc_test_fixes

Conversation

@JDBetteridge

Copy link
Copy Markdown
Contributor

Encountered when running outside of CI

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.53%. Comparing base (ce52ad1) to head (e041b0c).

Files with missing lines Patch % Lines
conftest.py 50.00% 2 Missing and 1 partial ⚠️
tests/test_mpi.py 25.00% 3 Missing ⚠️
devito/logger.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
- Coverage   83.55%   83.53%   -0.03%     
==========================================
  Files         257      257              
  Lines       53526    53536      +10     
  Branches     4583     4584       +1     
==========================================
- Hits        44726    44722       -4     
- Misses       8007     8019      +12     
- Partials      793      795       +2     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.37% <45.45%> (+<0.01%) ⬆️
pytest-gpu-gcc- 78.39% <52.63%> (-0.02%) ⬇️
pytest-gpu-icx- 78.33% <57.89%> (-0.03%) ⬇️
pytest-gpu-nvc-nvidiaX 69.03% <45.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JDBetteridge JDBetteridge changed the title tests: Miscelaneous fixes for the test suite tests: Miscellaneous fixes for the test suite Jul 1, 2026
@JDBetteridge JDBetteridge force-pushed the JDBetteridge/misc_test_fixes branch from 754998d to e041b0c Compare July 1, 2026 18:50
Comment thread devito/__init__.py

# Use any GPU present for parameters such as the padding by default. This can be
# disabled by setting this parameter to `0`, but should not be toggled.
configuration.add('gpu', 1, [0, 1], preprocessor=bool)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed, and in general, it seems off to have such an option in configuration

I'm not even sure I understand the comment above...

Why can we not use a combo of skipif and platform instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was needed because it was taking out my local machine!
Relevant discussion: https://devitocodes.slack.com/archives/C7JMLMSG0/p1778763735024689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants