compiler: Introduce operator lookup hook#2954
Open
EdCaunt wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2954 +/- ##
==========================================
- Coverage 83.60% 83.60% -0.01%
==========================================
Files 250 250
Lines 52908 52928 +20
Branches 4564 4566 +2
==========================================
+ Hits 44235 44249 +14
- Misses 7895 7901 +6
Partials 778 778
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| def __str__(self): | ||
| if self._subdomain is not None: | ||
| return (f"{self.__class__.__name__}({self.lhs}, {self.rhs}," |
Contributor
There was a problem hiding this comment.
nitpicking, this part of the fstring is identical to the one you return if no subdomain is present...
| expressions = cls._sanitize_exprs(expressions, **kwargs) | ||
|
|
||
| # Hook for retrieval of preexisting operators | ||
| # TODO: should this emit timing info if an operator is retrieved |
Contributor
There was a problem hiding this comment.
only in the hook, I'd say? so I guess you can drop this TODO comment...
EdCaunt
force-pushed
the
operator-lookup-hook
branch
from
afa93a8 to
86d0d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.