Repository navigation
chore: add native Vitest benchmarks and PR comparisons - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add readable, deterministic benchmark fixtures and native reference/candidate files. Use a separate PR workflow with native Vitest console and GitHub Actions reporters. Comparisons remain informational, with no uploads, custom runner, or performance threshold.
Update contributor, development, and release documentation. Update existing CI workflows and remove the shared setup action. No production source files change. No related issue was supplied.
Alternatives rejected: custom benchmark orchestration and stored CI artifacts.
Evidence
pnpm check,pnpm build, 20 library tests, 12 quick workloads, and 27 full workloads. A local paired full run produced 27 baseline and 27 candidate files. Native reporter validation produced comparison tables and a GitHub test summary for 12 quick cases, without changing baseline hashes. Actionlint passed for all four workflows.These results precede the final user edits. The pushed commit was not re-reviewed or re-tested. Benchmark callbacks measure performance only; existing library tests own correctness. No new benchmark correctness tests or runtime assertions were added. Hosted CI results remain pending.
Merge Danger
Door: two-way
Blast Radius: CI
Review the paired built-output transfer, workflow setup changes, and shared-action removal. This PR does not dispatch a release or publish a package.
AI assistance contributed implementation and earlier independent reviews. The user made final edits and committed and pushed them. The assistant did not review those final edits, as requested.