Repository navigation
Push the tag with a command that actually pushes it - #9
Merged
Merged
Conversation
`git push --follow-tags` pushes annotated tags only, and `git tag v1.0.1` makes a lightweight one — so the documented release recipe pushes the commit, reports success, and silently leaves the trigger behind. It did exactly that cutting 1.0.1. Naming the tag explicitly works for either kind. bump-version.mjs prints the same command, so it changes too. Also point the README's verification examples at v1.0.1. They named v1.0.0, which was uploaded to the store by hand and has no GitHub Release — `gh release download v1.0.0` would have failed for anyone who tried it. And correct the 1.0.1 changelog entry: it claimed the build reproduces 1.0.0's content digest. It cannot. The manifest version is one of the hashed files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three corrections found while cutting v1.0.1.
The documented release recipe does not push the tag.
git push --follow-tagspushesannotated tags only;
git tag v1.0.1creates a lightweight one. The push reports success,the tag stays local, and nothing triggers — which is what happened cutting 1.0.1, and had
to be fixed by hand.
git push origin main v1.1.0works for either kind.scripts/bump-version.mjsprints the same recipe, so it changes too.The README verification examples named v1.0.0, which was uploaded to the store by hand
and has no GitHub Release.
gh release download v1.0.0fails. They now name v1.0.1.The 1.0.1 changelog entry claimed the build reproduces 1.0.0's content digest. It
cannot —
public/manifest.jsoncarries the version and is one of the hashed files. Theentry now says what is actually true: the version string is the only difference under
src/orpublic/, and the digest necessarily differs because of it. The publishedrelease notes have been corrected to match.