Skip to content

fix(herdr-core): read Antigravity's antigravity as agy, so its pane gets its conversation - #2613

Merged
devswha merged 1 commit into
devswha:mainfrom
grandprixgp:fix/herdr-core-antigravity-name
Nov 2, 2026
Merged

devswha merged 1 commit into
devswha:mainfrom
grandprixgp:fix/herdr-core-antigravity-name

Conversation

@grandprixgp

Copy link
Copy Markdown
Contributor

Change

On the herdr-core runtime, hc reports Antigravity as antigravity, while the rest of the server knows it as agy. So an Antigravity pane got no conversation view. This adds it to the name map #2572 added for Claude Code.

Validation

  • bun test server/herdr-core/snapshot.test.ts server/herdr-core/adapter.test.ts scripts/changelog-fold.test.ts on main at a6aca2b: 61 pass, 0 fail
  • bun run typecheck on main at a6aca2b: passes
  • By hand on hc 0.1.16 on Linux: I started agy in a terminal, sent it a message, and /api/pane/conversation returned agy-transcript with both turns. That was on v0.4.22 with this patch applied.

Not run: bun run check fast in full and bun run check full.

A terminal started as sh -c <launcher> still falls back to scrollback, even when the launcher ends in exec agy, because hc reports sh as the foreground process. Starting it with exec avoids that, so I haven't changed it here.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: devswha/ovis
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: a6aca2b
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1932d29e-9d9a-4d23-a0e6-d6c57f6eca50
Commits

Reviewing files that changed from the base of the PR and between a6aca2b and 10dab33.

Files selected for processing: 3
  • changelog.d/herdr-core-antigravity-name.md
  • server/herdr-core/snapshot.test.ts
  • server/herdr-core/snapshot.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Summary

Summary by CodeRabbit

  • New Features
    • Ovis now recognizes Antigravity panes as Agy panes and displays their conversations alongside other Agy features. On the herdr-core runtime, Antigravity panes are labeled “agy.”

The herdr-core runtime maps the antigravity app name to agy. The snapshot test checks the pane and agent alias, and the changelog records the change.

Changes: herdr-core agent alias

Layer / File(s) Summary
Map and verify Antigravity alias
server/herdr-core/snapshot.ts, server/herdr-core/snapshot.test.ts, changelog.d/herdr-core-antigravity-name.md
HERDR_AGENT_NAMES maps antigravity to agy. The snapshot test checks the pane and agent expectations, and the changelog describes the mapping.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: devswha

Merge Risk: Minimal · up to 10dab

The Antigravity alias change is consistent across runtime behavior, tests, and documentation.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the herdr-core fix: map Antigravity's "antigravity" name to "agy" so the pane receives its conversation.
Description check Passed The description includes the required Change and Validation sections. It explains the name mismatch, resulting behavior, executed tests, manual validation, and skipped checks.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devswha

devswha commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Thanks @grandprixgp for the fix and the hand check on hc 0.1.16. On the herdr-core runtime hc reports Antigravity as antigravity, so its pane fell back to scrollback; with antigravity: "agy" in the name map (next to #2572's Claude Code entry) it takes the same paths as on herdr.

Merge-pass review (omo + Codex Terra xhigh): agentOfStatus is the only place hc's app name leaves herdr-core, so both the snapshot and live status events now say agy. Everything after that gates on the literal agy, and the agy transcript binding still needs exactly one foreground agy process in that pane (its own process record, its own locks, identity checked before and after), so the mapping cannot show another pane's or session's conversation. The new test fails without the change.

LOW, left as is: no adapter event-path test for antigravity (same function as the snapshot, and the claude-code event test covers that wiring); an agy started through sh -c still falls back to scrollback, as the PR says.

Not reproduced (inferred by Terra from the code, noted here, no follow-up): hc samples a pane's foreground process every 500 ms, so if Antigravity in one pane exits without clearing its status and another pane's Antigravity reuses that exact PID inside the same sample window, the first pane's lookup could see the second's process and lock. Linux PID reuse within half a second by another agy is not something a user realistically hits, and it is the same property the claude-code mapping from #2572 already has on herdr-core.

CodeRabbit reviewed it.

@devswha
devswha merged commit 5456638 into devswha:main Nov 2, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants