Repository navigation
fix(herdr-core): read Antigravity's antigravity as agy, so its pane gets its conversation - #2613
Conversation
…ets its conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Map and verify Antigravity alias server/herdr-core/snapshot.ts, server/herdr-core/snapshot.test.ts, changelog.d/herdr-core-antigravity-name.md |
HERDR_AGENT_NAMES maps antigravity to agy. The snapshot test checks the pane and agent expectations, and the changelog describes the mapping. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Suggested reviewers: devswha
Merge Risk: 
Minimal · up to 10dab
-
The Antigravity alias change is consistent across runtime behavior, tests, and documentation.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
Thanks @grandprixgp for the fix and the hand check on hc 0.1.16. On the herdr-core runtime hc reports Antigravity as Merge-pass review (omo + Codex Terra xhigh): LOW, left as is: no adapter event-path test for Not reproduced (inferred by Terra from the code, noted here, no follow-up): hc samples a pane's foreground process every 500 ms, so if Antigravity in one pane exits without clearing its status and another pane's Antigravity reuses that exact PID inside the same sample window, the first pane's lookup could see the second's process and lock. Linux PID reuse within half a second by another CodeRabbit reviewed it. |
Change
On the herdr-core runtime, hc reports Antigravity as
antigravity, while the rest of the server knows it asagy. So an Antigravity pane got no conversation view. This adds it to the name map #2572 added for Claude Code.Validation
bun test server/herdr-core/snapshot.test.ts server/herdr-core/adapter.test.ts scripts/changelog-fold.test.tson main at a6aca2b: 61 pass, 0 failbun run typecheckon main at a6aca2b: passesagyin a terminal, sent it a message, and/api/pane/conversationreturnedagy-transcriptwith both turns. That was on v0.4.22 with this patch applied.Not run:
bun run check fastin full andbun run check full.A terminal started as
sh -c <launcher>still falls back to scrollback, even when the launcher ends inexec agy, because hc reportsshas the foreground process. Starting it withexecavoids that, so I haven't changed it here.