Description of feature
There are currently quite a few examples of unused parameters, e.g. weight and sigma in build_nn:
|
def build_nn( # noqa: D103 |
This is likely to result in unexpected behaviour, and is a great potential source of bugs. There are other examples, like symm_ref_trans_prop in estimate_presence_score:
|
def estimate_presence_score( # noqa: D103 |
It's really hard to say though whether these are critical, without function docstrings (#19) and type hints (#20)
Description of feature
There are currently quite a few examples of unused parameters, e.g.
weightandsigmainbuild_nn:HNOCA-tools/src/hnoca/mapping/wknn.py
Line 51 in dcb4ea0
This is likely to result in unexpected behaviour, and is a great potential source of bugs. There are other examples, like
symm_ref_trans_propinestimate_presence_score:HNOCA-tools/src/hnoca/mapping/wknn.py
Line 189 in dcb4ea0
It's really hard to say though whether these are critical, without function docstrings (#19) and type hints (#20)