Skip to content

Bump org.apache.maven:apache-maven from 3.9.6 to 3.10.0 - #380

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/maven/org.apache.maven-apache-maven-3.10.0
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/maven/org.apache.maven-apache-maven-3.10.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 19, 2026

Copy link
Copy Markdown
Contributor

Bumps org.apache.maven:apache-maven from 3.9.6 to 3.10.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps org.apache.maven:apache-maven from 3.9.6 to 3.10.0.

---
updated-dependencies:
- dependency-name: org.apache.maven:apache-maven
  dependency-version: 3.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update java code labels Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage Report

Overall Project 95.19% 🍏

There is no coverage information present for the Files changed

@deweyjose deweyjose left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependabot bumps the Maven wrapper's distribution from apache-maven 3.9.6 → 3.10.0. The entire diff is one line in .mvn/wrapper/maven-wrapper.properties:3 (the distributionUrl). This is the build-time Maven version that ./mvnw downloads for maintainers and CI — it is not a dependency of the published plugin artifact and does not touch Codegen.java, any @Parameter, CodeGenConfigBuilder, or pom.xml.

  • Distribution exists and resolves: apache-maven-3.10.0-bin.zip → HTTP 200 from Maven Central.
  • Grep confirms the only apache-maven/version reference in the repo is this one wrapper line.

Build result

Ran locally against the PR head (72b860d) using the newly-pinned Maven 3.10.0 (wrapper downloaded and verified: Apache Maven 3.10.0):

  • ./mvnw -B -ntp verify spotless:check -pl graphqlcodegen-maven-plugin → BUILD SUCCESS — 68 tests run, 0 failures, 0 errors, 2 skipped; Spotless clean (29 files).
  • ./mvnw -B -ntp install (full reactor) → BUILD SUCCESS — all 8 modules green (plugin + common, server, client, client-introspection, kotlin-jackson3); example DGS runtime tests pass; server fetched its remote schema successfully.

Note: CI does not run on this branch yet (status pending) and per AGENTS.md fork PRs get no automatic build — the result above is from running the build directly, not from trusting checks.

Wiring completeness

N/A — no new/changed option, no boolean gap, no CodeGenConfigBuilder/constructor change. Nothing to thread through the layers.

Backwards compatibility

Breaking: NO. Walking the gate:

  • (a)–(c) no @Parameter/alias/property removed/renamed/retyped, no default changed, no generated output changed.
  • (d) does not raise the consumer-facing minimum Maven version. The wrapper version only dictates which Maven this repo builds itself with; the plugin's minimum Maven for consumers is governed by its prerequisites/enforcer, which are untouched. Goal name, goalPrefix, and default phase are unchanged. Java stays 17.
  • (e) not a generation-path dependency — apache-maven is the build tool, not graphql-dgs-codegen-core / kotlinpoet / graphql-java. Generated output cannot change from this.
  • (f) no transitive runtime dependency of consumers changes.

So the backwards-compatibility gate does not block this PR.

Risks

  • Low. The bump changes the Maven version used by every ./mvnw-driven workflow (build.yaml, coverage.yml, e2e-example.yaml, and publish.yaml). A release would publish to Maven Central using Maven 3.10.0; releases are irreversible, so the maintainer should want the end-to-end build green on main before the next release — the full-reactor run above is reassuring on that front.
  • 3.10.0 is a recent Maven line; no behavioral issue observed across the reactor here.

Verdict: COMMENT (review-only — not approving, not merging)

Not a breaking change, and the build is green, but this falls outside the Dependabot auto-merge scope: that path is limited to changes "limited to pom.xml dependency metadata," and this is a Maven wrapper toolchain bump (.mvn/wrapper/maven-wrapper.properties), not a pom.xml dependency. Leaving the merge decision to the maintainer.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant