Repository navigation
Bump ch.qos.logback:logback-classic from 1.6.5 to 1.6.6 - #384
Conversation
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.6.5 to 1.6.6. - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.6.5...v_1.6.6) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-version: 1.6.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Code Coverage Report
|
deweyjose
left a comment
There was a problem hiding this comment.
Review: Bump logback-classic 1.6.5 → 1.6.6
Summary
Dependabot patch bump of ch.qos.logback:logback-classic (1.6.5 → 1.6.6) in graphqlcodegen-maven-plugin/pom.xml:102. Single-line change to dependency version metadata; no source, no config surface touched.
Build result
Ran locally against the PR head (70fbe54):
./mvnw -B -ntp verify -pl graphqlcodegen-maven-plugin→ BUILD SUCCESS, Tests run: 68, Failures: 0, Errors: 0, Skipped: 2.spotless:check→ clean (29 files).
Wiring completeness
N/A — no @Parameter / CodeGenConfig option added or changed, so no Codegen/Provider/Executor/Builder/README wiring to verify.
Backwards compatibility — NOT breaking
- No
@Parameteradded/removed/renamed/retyped; no default changed; no goal/phase/Java/Maven change. logback-classicis not on the generation path (notgraphql-dgs-codegen-core,kotlinpoet, orgraphql-java), so generated output is unaffected.- It is the plugin's own logging implementation. Maven plugin dependencies load in the plugin's isolated class realm at build time; they are not propagated to consuming projects' compile/runtime classpath, so this is not a consumer-runtime transitive change.
version-update:semver-patchper the Dependabot metadata; release notes are bug/hardening fixes (serialization hardening, FileNamePattern regex escaping, MDC ordering), no API changes relevant here.
Risks
Minimal. Patch-level logging dependency, build and all tests green.
Verdict: APPROVE
Meets all Dependabot auto-merge conditions (dependabot author, patch bump, off generation path, verify passes, pom-metadata-only, no breaking-change label). Merging.
Generated by Claude Code
Bumps ch.qos.logback:logback-classic from 1.6.5 to 1.6.6.
Release notes
Sourced from ch.qos.logback:logback-classic's releases.
Commits
a9ee801prepare release 1.6.67fa8e8ethrow ScanException on unmatched '}' during variable substitution, fixes #836355b931Test round trip of circular exceptions through LoggingEventVOc7b8e2freject cyclic throwable proxies in LoggingEventVO.readObject6217f11fix loging of ThrowableProxy constructor taking isCyclic boolean0b95858LOGBACK-1337 LogbackMDCAdapter should store mdc in LinkedHashMap to predict o...5c1f577add LinkedHashMap to HardenedObjectInputStream whitelist7c36c71Escape regex metacharacters in date patterns, harden rolling testsd268774Align date pattern to regex conversion with DateTimeFormatterb4b4828Escape regex metacharacters of literal text in FileNamePattern regexesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)