Skip to content

Fix stale user identity after logout #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootverdict wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stale user identity after logout #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions e2e/tests/administrator/dashboard.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,14 @@ test('create case with empty name should present error', async ({ page }) => {
await expect(page.getByText('Invalid data type')).toBeVisible();
});

test('logout should go back to login page', async ({ page }) => {
test('logout should clear cached user identity and go back to login page', async ({ page }) => {
await page.evaluate(() => {
sessionStorage.setItem('userWhoami', JSON.stringify({ user_id: 1234 }));
});

await page.getByRole('link', { name: 'administrator' }).click();
await page.getByRole('link', { name: 'Logout' }).click();

await expect(page.getByRole('button', { name: 'Sign In' })).toBeVisible();
})
expect(await page.evaluate(() => sessionStorage.getItem('userWhoami'))).toBeNull();
});
2 changes: 1 addition & 1 deletion source/app/templates/includes/sidenav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</a>
</li>
<li>
<a href={{ url_for('dashboard_rest.logout') }}>
<a href="{{ url_for('dashboard_rest.logout') }}" onclick="sessionStorage.removeItem('userWhoami');">
<span class="link-collapse">Logout</span>
</a>
</li>
Expand Down