Repository navigation
feat: an entity panel can be scoped to asset types and own profile fields - #90
Merged
Merged
Conversation
…elds A scoped tab shows only on assets of its types, and the fields it edits leave the metadata sheet there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entity panels (the tabs and cards a distribution adds to asset pages) showed on every asset. Two optional keys on
EntityPanel:assetTypes: profile asset types the panel is for. A tab scoped toline_of_businessonly appears on lines of business.EntityRefnow carries the asset'sassetType.fields: profile fields the panel edits itself. Where the panel shows, the metadata sheet leaves those fields out, and their incoming links out of "Linked from other assets", so the same thing is not edited in two places.Panels without the keys behave as before.
tests/entity-panels.test.tscovers both; Prettier passes and ESLint only reports the two pre-existing external-link errors.