Repository navigation
feat: a source can name linked assets by MRN and ingestion stores their IDs - #92
Merged
Merged
Conversation
…ir IDs A link field written with MRNs is resolved on write; a run fills, on a second pass, the fields that named assets created later in the same batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A profile field with
control: assetstores asset IDs. A connector only knows MRNs, so it could not fill one: the value was stored as text the sheet does not recognise.mrn://…in an asset-control field is replaced by the ID of the asset it names. An MRN that names nothing is left out. Applies to any writer (API included); plain IDs are checked as before.DeferLinks), so a partial value is never stored and then mistaken for a curated one. After the batch, the assets that carried MRNs are written once more, now that every target exists.Also moves the two database tests of
internal/core/assettoasset_test:pgtestreaches the package through the plugin registry, and the import cycle kept the whole package's tests from compiling.Tests:
go test ./internal/core/asset/ ./internal/core/runs/ ./internal/core/contentpack/, with and withoutMARMOT_TEST_POSTGRES_DSN; newTestProcessEntities_LinksByMRNAnAssetCreatedLaterInTheSameRunandTestAnMRNLinkResolvesOnceItsTargetExists.