Repository navigation
feat: an asset link can be declared acyclic and the server refuses a loop - #93
Merged
Merged
Conversation
…ir IDs A link field written with MRNs is resolved on write; a run fills, on a second pass, the fields that named assets created later in the same batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the ingestion PR (
feature/ingest-link-mrns): merge that one first; this one then shows only its own commit.A hierarchy built with an asset link (a line of business and its parent area) could be closed into a loop: A under B and B under A. Only the interface prevented it.
acyclic: true, accepted on fields withcontrol: assetonly.cycle. The walk is bounded (256 assets).asset-metadata.md.Tests:
TestAnAcyclicLinkCannotLeadBackToTheAsset,TestAcyclicNeedsTheAssetControl.