Repository navigation
feat: product and glossary term sheets get the folding sections of the asset sheet - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProductGovernedFields(data products and glossary terms) kept the flat key/value table the asset sheet had before #86 and #87. It now has the same layout: progress header with the jump to the required fields missing, sections with their progress bar that fold, empty optional fields behind "Show fields without a value", and label/value rows.The markup and the section logic are the asset sheet's; saving is untouched (products and terms still replace their metadata with a PUT).
Prettier passes; ESLint only reports the two pre-existing external-link errors. Exercised in a browser on a glossary term against a mocked API, light and dark. Not exercised on a data product.