Restore giscus comments on all posts - #38
Merged
Merged
Conversation
Wire giscus into the theme's native comments provider so every post gets a comment box automatically. Remove the hand-pasted github-comments include from 15 posts to avoid duplicate widgets.
Setting `repository` activates jekyll-github-metadata, which infers a wrong baseurl without API access. Pinning both makes local and Pages builds behave the same.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
diffuse-website | d0c2bba | Jul 28 2026, 08:12 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Comments had silently disappeared from most posts. They were never wired into the layout. Instead,
{% include github-comments.html %}was pasted by hand at the bottom of each post body, and new posts stopped copying that line. Only 15 of 32 posts still had it, the most recent from February 2026._config.ymlalso defaulted posts tocomments: false, so any post that forgotcomments: truein its front matter got nothing either.Fix
comments: trueurlandbaseurlexplicitlydiscussion_termis set totitle, matching the olddata-mapping="title", so existing GitHub Discussions reattach to their original posts rather than starting fresh.Why url and baseurl are pinned
Setting
repositoryis required by the theme's giscus include fordata-repo, but it also activatesjekyll-github-metadata, which then infers a wrongbaseurlof/pages/diff-useand breaks every link on the site. Pinning both values overrides that inference and makes local and Pages builds behave identically. There's a comment in_config.ymlexplaining this so the lines don't get removed later.Verification
Production build (
JEKYLL_ENV=production bundle exec jekyll build):<section id="giscus-comments">/pages/diff-usereferences anywhere in the outputNote that comments are intentionally hidden in dev builds. The theme shows a "disabled in non-production environments" placeholder instead, so the production flag is needed to see them locally.
Expected check failures
main, since Cloudflare builds the production branch only. It was red on PRs made team member changes #33, Update Careers postings #34, and Add PLUG blog post with overview figure and author update #35, all of which merged fine.diff-use/github-workflowsis private while this repo is public, and GitHub rejects that with "Workflows cannot be required from a less visible repository." Unrelated to the contents of this PR.Out of scope
_posts/2025-11-10-allhands.mdand_posts/2026-02-02-allhands.mdboth build to/posts/allhands/, so one silently overwrites the other. Pre-existing and left alone here, since fixing it changes a published URL.