Skip to content

secret-scan: fail-closed dedup range, merge-base anchor, mrkdwn escaping - #4

Merged
Abdelsalam-Abbas merged 1 commit into
mainfrom
abbas1/eng-552-review-fixes
Aug 3, 2026
Merged

secret-scan: fail-closed dedup range, merge-base anchor, mrkdwn escaping#4
Abdelsalam-Abbas merged 1 commit into
mainfrom
abbas1/eng-552-review-fixes

Conversation

@Abdelsalam-Abbas

Copy link
Copy Markdown
Collaborator

Manual sync of Astera-org/github-workflows#6 (post-merge review fixes to #3). See that PR for full rationale.

  • Validate the dedup scan range up front and fall back to full-history alerting on any doubt (gitleaks exits 0 on an unresolvable range, so this previously dropped alerts silently).
  • Anchor the range on merge-base(origin/base, head) instead of the stale event base.sha, so merging the base branch into a PR no longer re-attributes its findings.
  • Default notify_count to 0 (zero-byte report previously failed the step under set -e).
  • Entity-escape Slack mrkdwn in sample lines (crafted file names could render as disguised links).
  • Skip the incremental scan when no Slack token is present; clearer skip log line.

@Abdelsalam-Abbas
Abdelsalam-Abbas merged commit 2cd5389 into main Aug 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant