goto-diff: add missing break in output_functions UI switch#9084
Merged
Conversation
The XML_UI case of the user-interface switch in goto_difft::output_functions fell through to the next case. Add the missing break so --xml-ui emits only its own "not supported yet" message. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
5 tasks
peterschrammel
approved these changes
Jun 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates goto-diff’s goto_difft::output_functions() UI switch to add an explicit break; in the XML_UI case.
Changes:
- Add
break;after emitting the"XML output not supported yet"message in theXML_UIcase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9084 +/- ##
========================================
Coverage 80.68% 80.68%
========================================
Files 1714 1714
Lines 189593 189593
Branches 73 73
========================================
Hits 152979 152979
Misses 36614 36614 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML_UI case of the user-interface switch in goto_difft::output_functions fell through to the next case. Add the missing break so --xml-ui emits only its own "not supported yet" message.