Skip to content

goto-diff: add missing break in output_functions UI switch#9084

Merged
tautschnig merged 1 commit into
diffblue:developfrom
tautschnig:goto-diff-break
Jun 25, 2026
Merged

goto-diff: add missing break in output_functions UI switch#9084
tautschnig merged 1 commit into
diffblue:developfrom
tautschnig:goto-diff-break

Conversation

@tautschnig

Copy link
Copy Markdown
Collaborator

The XML_UI case of the user-interface switch in goto_difft::output_functions fell through to the next case. Add the missing break so --xml-ui emits only its own "not supported yet" message.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The XML_UI case of the user-interface switch in goto_difft::output_functions
fell through to the next case. Add the missing break so --xml-ui emits only
its own "not supported yet" message.

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
@tautschnig tautschnig self-assigned this Jun 24, 2026
Copilot AI review requested due to automatic review settings June 24, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates goto-diff’s goto_difft::output_functions() UI switch to add an explicit break; in the XML_UI case.

Changes:

  • Add break; after emitting the "XML output not supported yet" message in the XML_UI case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/goto-diff/goto_diff_base.cpp
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.68%. Comparing base (7483d0d) to head (19f9f84).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9084   +/-   ##
========================================
  Coverage    80.68%   80.68%           
========================================
  Files         1714     1714           
  Lines       189593   189593           
  Branches        73       73           
========================================
  Hits        152979   152979           
  Misses       36614    36614           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit fab2918 into diffblue:develop Jun 25, 2026
43 checks passed
@tautschnig tautschnig deleted the goto-diff-break branch June 25, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants