Skip to content

ci: remove the diffpy.srfit 3.4.0rc0 bridge and require srfit>=3.4.0 - #13

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:rm-srfit-rc-pin
Oct 27, 2026
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:rm-srfit-rc-pin

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

Closes #6

srfit 3.4.0 is on conda-forge, so CI no longer needs to pip install the
rc (reverts 000e71b). cmipdf calls methods that srfit 3.3.1 lacks (19 of
49 tests fail with it), so declare the lower bound in conda.txt and
pip.txt.

Closes diffpy#6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (2b2ef8a) to head (e8d8ee0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files           6        6           
  Lines         264      264           
=======================================
  Hits          254      254           
  Misses         10       10           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
sbillinge merged commit bdaf436 into diffpy:main Oct 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove diffpy.srfit rc pin when srfit 3.4.0 is a full release

2 participants