Repository navigation
fix: match cf names to srfit 3.4.0 - #16
Merged
Merged
Conversation
srfit 3.4.0 deprecated lognormalSphericalCF and shellCF in favor of lognormal_spherical_particle and shell_particle. Using different names in cmipdf would make users who already moved to the 3.4.0 names rename a second time. Rename lognormal_spherical_distribution and spherical_shell in characteristicfunctions.py so every characteristic function name and argument matches srfit 3.4.0, and correct the unreleased fix-cfs news. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fix-cfs news item, which is not released yet, already covers the characteristic function changes and now lists the srfit 3.4.0 names, so this PR needs no separate entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 6 6
Lines 264 264
=======================================
Hits 254 254
Misses 10 10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is coupled to this srfit PR: diffpy/diffpy.srfit#238